Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate uniforms-material theme #1338

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Deprecate uniforms-material theme #1338

merged 7 commits into from
Jun 17, 2024

Conversation

zendranm
Copy link
Member

@zendranm zendranm commented May 24, 2024

Deprecating the Material theme, as mentioned in this issue (#1315).

  • Removed the whole package from the uniforms repository
  • Removed package from the labeler
  • Removed Material from the Readme file
  • Removed the uniforms-material package from the package.json files
  • Removed theme from tsconfig references
  • Removed skipTestIf from test suites

@github-actions github-actions bot added Area: Infra Affects the repository itself (e.g., CI, dependencies) Area: Theme Affects some of the theme packages Area: Docs Affects the documentation or reproductions seed Theme: Material-UI Affects the uniforms-material package labels May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (c047291) to head (946faf6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   94.35%   95.05%   +0.69%     
==========================================
  Files         200      175      -25     
  Lines        3314     2892     -422     
  Branches      895      763     -132     
==========================================
- Hits         3127     2749     -378     
+ Misses         70       59      -11     
+ Partials      117       84      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Area: Core Affects the uniforms package label May 24, 2024
@kestarumper kestarumper linked an issue May 28, 2024 that may be closed by this pull request
@kestarumper kestarumper changed the title Deprecate material theme Deprecate uniforms-material theme May 28, 2024
@kestarumper kestarumper mentioned this pull request May 28, 2024
@zendranm zendranm marked this pull request as ready for review May 31, 2024 10:45
@zendranm zendranm self-assigned this May 31, 2024
kestarumper
kestarumper previously approved these changes Jun 3, 2024
@kestarumper
Copy link
Member

I wonder if we should add somewhere in the docs an admonition that this theme has been deprecated.
But I don't know where since there are no dedicated pages for a theme.

@wadamek65
Copy link
Contributor

@kestarumper Maybe you could add it in the installation section when picking the material theme? It's probably very niche but better than nothing I suppose.
image

@kestarumper
Copy link
Member

@wadamek65, but we're getting rid of the Material tab button fully (this is because we're deleting all dependencies such as styles, etc).

@wadamek65
Copy link
Contributor

@kestarumper Then another option would be modifying the README in the package itself, so at least it will be shown on the npm page of the package.

@kestarumper
Copy link
Member

@wadamek65 well, we're deleting the README too 😅.
We planned to use the NPM deprecation message.

@wadamek65
Copy link
Contributor

@kestarumper Then I'm out of ideas 😖

@Monteth
Copy link
Member

Monteth commented Jun 14, 2024

@kestarumper We can release the last version with deprecation info and then remove the package, so in the history, there will be a readme with a message.

Monteth
Monteth previously approved these changes Jun 14, 2024
ErnestTeluk
ErnestTeluk previously approved these changes Jun 14, 2024
@ErnestTeluk
Copy link
Contributor

conflict to fix

@zendranm zendranm dismissed stale reviews from ErnestTeluk, Monteth, and kestarumper via 946faf6 June 14, 2024 11:51
@zendranm zendranm requested a review from kestarumper June 15, 2024 21:29
@zendranm zendranm merged commit 2a116fb into master Jun 17, 2024
7 checks passed
@zendranm zendranm deleted the deprecate-material-theme branch June 17, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Affects the uniforms package Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies) Area: Theme Affects some of the theme packages Theme: Material-UI Affects the uniforms-material package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate packages
5 participants