-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated ListItemField
tests to @testing-library/react
#1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Core
Affects the uniforms package
Area: Theme
Affects some of the theme packages
Theme: Bootstrap 3
Affects the uniforms-bootstrap3 package
Theme: Unstyled
Affects the uniforms-unstyled package
labels
Feb 15, 2024
github-actions
bot
added
Theme: AntD
Affects the uniforms-antd package
Theme: Bootstrap 4
Affects the uniforms-bootstrap4 package
Theme: Bootstrap 5
Affects the uniforms-bootstrap5 package
Theme: Material-UI
Affects the uniforms-material package
Theme: MUI
Affects the uniforms-mui package
Theme: Semantic UI
Affects the uniforms-semantic package
labels
Feb 16, 2024
piotrpospiech
changed the title
Migrate ListItemField tests from Enzyme
Migrated Feb 16, 2024
ListItemField
tests to @testing-library/react
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 231 231
Lines 3821 3821
Branches 1029 1029
=======================================
Hits 3617 3617
Misses 82 82
Partials 122 122 ☔ View full report in Codecov by Sentry. |
piotrpospiech
requested review from
wadamek65 and
kestarumper
as code owners
February 16, 2024 08:20
kestarumper
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Core
Affects the uniforms package
Area: Theme
Affects some of the theme packages
Theme: AntD
Affects the uniforms-antd package
Theme: Bootstrap 3
Affects the uniforms-bootstrap3 package
Theme: Bootstrap 4
Affects the uniforms-bootstrap4 package
Theme: Bootstrap 5
Affects the uniforms-bootstrap5 package
Theme: Material-UI
Affects the uniforms-material package
Theme: MUI
Affects the uniforms-mui package
Theme: Semantic UI
Affects the uniforms-semantic package
Theme: Unstyled
Affects the uniforms-unstyled package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is part of #1130
ListItemField
RTL suitesListItemField
testsRemoved
renders AutoField
test, because there is no way to check if default children component will be rendered in RTL.renders children if specified
test is testing similar behaviour.