Create theme command #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnestTeluk
requested review from
a team,
kestarumper,
Monteth,
zendranm,
DamianErtel,
zaxovaiko and
piotrpospiech
| @@ -15,6 +15,8 @@ | |||
| "import/no-extraneous-dependencies": 0, | |||
| "import/prefer-default-export": 0, | |||
| "@typescript-eslint/no-shadow": 0, | |||
| "no-restricted-syntax": 0 | |||
| "no-restricted-syntax": 0, | |||
There was a problem hiding this comment.
I would reconfigure eslint. Most of plugins are unnecessary, for example eslint-plugin-react.
There was a problem hiding this comment.
i will do it in next pr, also add husky and some sort of ci to test lints on branch
There was a problem hiding this comment.
Ok, but don't focus on husky. Configure CI first. Git hooks can be controversial topic.
piotrpospiech
approved these changes
Oct 29, 2024
DamianErtel
approved these changes
Nov 15, 2024
zaxovaiko
approved these changes
Nov 15, 2024
zendranm
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add create theme command that copy uniforms-unstyled from GitHub and copy it to specified folder