13505 - Prevent GameRefresher moving Decks with duplicate names #13507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrentEaston
added
bug
|
|
||
| if (first == null) { | ||
| first = pile; | ||
| if (deck.getMap().equals(pile.getMap())) { |
There was a problem hiding this comment.
Am I misunderstanding something here, or should this if statement be outside of the (first == null) check, instead of within it? Is it not possible that you would find a match on the same map after finding a match on an earlier map? As written, it looks to me like it stops checking for a matching map once it's found any matching deck name.
There was a problem hiding this comment.
Thanks Jonathon, my cut and paste hatchet job got out of hand. That code makes no sense at all. I have committed a new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.