More efficient Regex search with improved user experience. #12775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverwanderer
added
bug
… editor-search-regex-revamp # Conflicts: # vassal-app/src/main/java/VASSAL/configure/ConfigureTree.java
…Search session clarification in doc.
… or not found, show Regex pattern specifically, in case of default.
…ing (unlike underline elsewhere).
|
I've tried to make the Regular Expression option more usable and more efficient. I think it's working now, external testing and feedback welcome. I've also tweaked the search "matches found or not" headings to make the output very slightly more readable. |
|
I've noticed the my attempt to detect a lack of Regex and apply a default doesn't seem that reliable. I am looking into it. |
riverwanderer
added
Review-In Progress
|
Sounds like still a "Work in Progress"? pending regex detection? |
Yes, I will be submitting a branch from this PR that offers normal, word start and full regex as radio button options along with some other enhancements. |
riverwanderer
added
On Hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try a re-vamp of Regex search.