Minor code doc correction #12756
Closed
Minor code doc correction #12756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pre & Post GHK, always try. Doc updated.
This reverts commit 0ee8714.
uckelman
reviewed
Sep 28, 2023
| @@ -496,6 +496,7 @@ public void finish() { | |||
| if (GameModule.getGameModule().isMultiplayerConnected()) { | |||
| final Command c = new Chatter.DisplayText(GameModule.getGameModule().getChatter(), Resources.getString(GlobalOptions.getInstance().chatterHTMLSupport() ? "PlayerRoster.joined_side_2" : "PlayerRoster.joined_side", GameModule.getGameModule().getPrefs().getValue(GameModule.REAL_NAME), translateSide(newSide))); | |||
| c.execute(); | |||
| GameModule.getGameModule().getServer().sendToOthers(c); | |||
There was a problem hiding this comment.
Is this change intended to be included?
There was a problem hiding this comment.
Not really. That change is in PR #12750.
There was a problem hiding this comment.
It looks like the only commit which should be in this PR is 635bc26, in that case.
Would you be able to drop the other commits? (The simplest way is probably an interactive rebase.)
There was a problem hiding this comment.
That's not what I meant---the unnecessary commits are still there, plus one more which undoes them. What I was asking for was a rebase that takes those commits out of the PR.
riverwanderer
added
Build Only - Do not merge
and removed
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File extension = vsav.