Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12708 - Prevent ArrayIndexOutOfBoundsException if side translation count does not match module #12700

Merged
merged 2 commits into from
Sep 18, 2023
Merged

12708 - Prevent ArrayIndexOutOfBoundsException if side translation count does not match module #12700

merged 2 commits into from
Sep 18, 2023

Conversation

BrentEaston
Copy link
Collaborator

@BrentEaston BrentEaston commented Sep 15, 2023 •
edited
Loading

If the number of sides defined in the current translation does not math the number of sides defined in the module then

  1. Report a Validation error when saving module from Editor (and in errorlog when loading module)
  2. Do not translate sides in Player mode
  3. Add warning message to chat window in Player mode.

Also includes earlier tweaks to side translation.

@BrentEaston BrentEaston added bug Something isn't working Work In Progress Ready for Review Ready to be reviewed for Merging and removed Work In Progress labels Sep 15, 2023
@BrentEaston BrentEaston added this to the 3.7.1 milestone Sep 16, 2023
@BrentEaston BrentEaston changed the title Side Translation tweaks 12708 Prevent Array out of Bounds exception if side translation count does not match module Sep 17, 2023
@BrentEaston BrentEaston linked an issue Sep 17, 2023 that may be closed by this pull request
[Napoléon 1815] ArrayIndexOutOfBoundsException: Index 3 out of bounds for length 3 #12708
Closed
@uckelman uckelman changed the title 12708 Prevent Array out of Bounds exception if side translation count does not match module 12708 - Prevent ArrayIndexOutOfBoundsException if side translation count does not match module Sep 18, 2023
@uckelman uckelman merged commit 8678d33 into vassalengine:master Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working Ready for Review Ready to be reviewed for Merging
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.

[Napoléon 1815] ArrayIndexOutOfBoundsException: Index 3 out of bounds for length 3
2 participants
@BrentEaston @uckelman