Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12670 - Prevent essential components being accidentally deleted #12671

Merged
merged 4 commits into from
Sep 12, 2023
Merged

12670 - Prevent essential components being accidentally deleted #12671

merged 4 commits into from
Sep 12, 2023

Conversation

BrentEaston
Copy link
Collaborator

No description provided.

@BrentEaston BrentEaston added enhancement New feature or request Ready for Review Ready to be reviewed for Merging labels Sep 8, 2023
@BrentEaston BrentEaston added this to the 3.8.0 milestone Sep 8, 2023
@uckelman
Copy link
Contributor

I don't see anything here that would be backwards incompatible. Could this be in 3.7?

@BrentEaston BrentEaston linked an issue Sep 10, 2023 that may be closed by this pull request
Prevent Module Designer from deleting essential components #12670
Closed
@BrentEaston BrentEaston added Work In Progress and removed Ready for Review Ready to be reviewed for Merging labels Sep 10, 2023
@BrentEaston BrentEaston modified the milestones: 3.8.0, 3.7.1 Sep 10, 2023
@BrentEaston BrentEaston added Ready for Review Ready to be reviewed for Merging and removed Work In Progress labels Sep 11, 2023
@BrentEaston
Copy link
Collaborator Author

I'm not actually very happy with this, I am going to redo it, back to the Buildable level and implement a set of new default methods isMandatory() = false, isMovable() = true and isUnique() = false so all Buildables can register themselves as to how they want to be treated by the ConfigureTree.

And yes. it will be 3.7 compatible.

@uckelman
Copy link
Contributor

Is this the way you want it to be now?

@BrentEaston
Copy link
Collaborator Author

Yes, this is good to go. More widespread changes, but it is actually much simpler and supports custom components.

@uckelman uckelman merged commit 799c990 into vassalengine:master Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uckelman uckelman uckelman left review comments

Assignees
No one assigned
Labels
enhancement New feature or request Ready for Review Ready to be reviewed for Merging
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.

Prevent Module Designer from deleting essential components
2 participants
@BrentEaston @uckelman