Merge pull request #12707 from riverwanderer/12706-side-related-initi…

…al-states

12706-keep the "retire" button disabled unless a game is running.

vassal-app/src/main/java/VASSAL/build/module/PlayerRoster.java

@@ -108,7 +108,8 @@ public PlayerRoster() {
       "",
       e -> launch()
     ));
-    getLaunchButton().setVisible(false);
+    getLaunchButton().setEnabled(false); // not usuable without a game
+   // getLaunchButton().setVisible(false);
     retireButton = getLaunchButton(); // for compatibility
 
     setShowDisabledOptions(false); //AbstractToolbarItem
@@ -451,7 +452,8 @@ public void setup(boolean gameStarting) {
       GameModule.setTempUserId(null);
       players.clear();
     }
-    getLaunchButton().setVisible(gameStarting && getMySide() != null);
+    // getLaunchButton().setVisible(gameStarting && getMySide() != null);
+    getLaunchButton().setEnabled(gameStarting);
     pickedSide = false;
   }
 
@@ -480,7 +482,9 @@ public void finish() {
       a.execute();
       GameModule.getGameModule().getServer().sendToOthers(a);
     }
-    getLaunchButton().setVisible(getMySide() != null);
+    // button is enabled / disabled at start and end of games.
+    // not clear what purpose is served by adjusting button visibility here
+    // getLaunchButton().setVisible(getMySide() != null);
     pickedSide = true;
   }