Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h2: Add a rate limit facility for h/2 RST handling (6.0) #4008

Merged
merged 10 commits into from
Oct 18, 2023
Merged

h2: Add a rate limit facility for h/2 RST handling (6.0) #4008

merged 10 commits into from
Oct 18, 2023

Conversation

dridi
Copy link
Member

@dridi dridi commented Oct 18, 2023

This is a port of #3997 and #3999 mostly performed by @daghf.

asadsa92 and others added 10 commits October 18, 2023 17:33
@asadsa92 @dridi
vdef: implement vmin[_t], vmax[_t] and vlimit[_t]
078a4a4 
This should make the code easier to read and stop us from being inconsistent.

Signed-off-by: Asad Sajjad Ahmed <[email protected]>
@daghf @dridi
h2: Add a rate limit facility for h/2 RST handling
109f5db 
This adds parameters h2_rapid_reset_limit and h2_rapid_reset_period,
which govern the rate of which we permit clients to reset streams.

If the limit is exceeded the connection is closed.

Related to: varnishcache#1851

Conflicts:
	include/tbl/params.h
@daghf @dridi
Introduce RAPID_RESET as a sess_close reason
2f12eb5 
Conflicts:
	bin/varnishd/VSC_main.vsc
	include/tbl/sess_close.h
@bsdphk @dridi
Flexelinting
0aa2551
@daghf @dridi
Add param h2_rapid_reset
c4f4416 
Only RST frames received earlier than this duration will be considered
rapid.

Includes backports of the following upstream doc-touchups:
- 151f4d5
- 46d4f82

Conflicts:
	include/tbl/params.h
@daghf @dridi
h2: Set a default h2_rapid_reset_limit
24470e2
@daghf @dridi
Copy rapid reset parameters to the h2 session
2ed3c8e 
backport of f820f80

Conflicts:
	include/tbl/params.h
@daghf @dridi
Add vmod_h2 to control rapid_reset parameters per session
3902850 
Backport of 2cfb561 and 1a406e3

Conflicts:
	bin/varnishtest/vmods.h
	configure.ac
	lib/Makefile.am
@daghf @dridi
vmod_h2: VRT_fail if called outside of client context
c2bc7d1
@nigoroll @dridi
Flexelinting
822995f 
we can not make the parameter const because API.
@dridi dridi mentioned this pull request Oct 18, 2023
Closed
@dridi
Copy link
Member Author

dridi commented Oct 18, 2023

Once again, failing tests are timing out and registered in #4002, ready to merge.

@dridi dridi merged commit b9ef357 into varnishcache:6.0 Oct 18, 2023
@dridi dridi deleted the pulls_3997_3999_6.0 branch October 18, 2023 16:40
@pereorga pereorga mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
b=enhancement c=H/2 r=6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dridi @asadsa92 @daghf @bsdphk @nigoroll