Collect bug fixes for 7.3.1 #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with uds abstract sockets, sun_path should start with a NULL character followed by the socket's name. The name is not considered to be NULL terminated and can contain NULL bytes which have no special meaning. socklen is used to determine the length of name and must be set to the length of the struct sockaddr_un up to the last character of name, otherwise the 108 characters of sun_path will be treated as the name of the socket, including NULL bytes.
This requirement was dropped in the updated rfc 9113. Fixes: varnishcache#3911
|
TODO: pick c83cc81 too. |
|
Another candidate: #3930 |
|
I guess #3958 also |
The VSB bits in here come with a very significant performance penalty for H2 request body processing.
|
And #3957 too. |
Suppose the following happens: vbp_task() finishes with vt->running = 0 and a heap insert. The vbp_cond is signaled under the lock, but now instead of vbp_thread() waking up first, VBP_Remove() gets the lock and reaches assert(vt->heap_idx == VBH_NOIDX) before the racing vbp_thread() deleted the heap. This is unlikely to happen with static backends, because for those, the probe is stopped via the vcl temperature before they get removed. Fixes nigoroll/libvmod-dynamic#100
|
This is blocking the release of 7.3.1, see #3996. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a list of bug fixes candidates for a 7.3.1 release:
Please note that only the first one was merged, we didn't get a chance to formally approve them during the last bugwash.