vmod_h2: VRT_fail if called outside of client context

varnishcache · Oct 18, 2023 · 0ecefa8 · 0ecefa8
1 parent cfba263
commit 0ecefa8
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/libvmod_h2/vmod_h2.c b/lib/libvmod_h2/vmod_h2.c
@@ -43,7 +43,12 @@ h2get(VRT_CTX)
 	uintptr_t *up;
 
 	CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC);
-	CHECK_OBJ_NOTNULL(ctx->req, REQ_MAGIC); // $Restrict client
+	if (ctx->req == NULL) {
+		VRT_fail(ctx,
+		    "vmod_h2 can only be called from client-side VCL.");
+		return (NULL);
+	}
+	CHECK_OBJ_NOTNULL(ctx->req, REQ_MAGIC);
 	if (ctx->req->transport != &H2_transport)
 		return (NULL);
 	AZ(SES_Get_proto_priv(ctx->req->sp, &up));