replace structlog with containerlog #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewHink
reviewed
Dec 12, 2021
|
Thumbs up emoji? Really? Kiss my ass fool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
We come full circle. Containerlog was written to be more peformant because the perf testing on synse-server showed logging was adding a non-trivial amount to request latency. Now, containerlog can hopefully improve that request latency a little bit (:
There is one caveat here - I had to do some real Dockerfile surgery. I'm not sure whats up, but building locally, the docker image just straight up failed. I think the new image isn't as streamlined, but it actually works. I think it'd be good for someone to test the docker build out of vapor-ware's develop branch to confirm/refute whether what I'm seeing is actually true, or if it could be some misconfiguration on my machine. Happy to take out the Dockerfile changes if they aren't actually needed.
fixes #399