Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE Feat: Quickstart using the middleware #403

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE Feat: Quickstart using the middleware #403

wants to merge 10 commits into from

Conversation

OjusWiZard
Copy link
Member

No description provided.

DavidMinarsch
DavidMinarsch reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Delete everything in run_service.sh that has already been migrated to run_service.py
  2. Same for stop.sh and stop.py
  3. Extract anything in service.py that's configuration specific to the trader into a quickstart.json file.
  4. stop and run need to work

@OjusWiZard OjusWiZard changed the title Feat/trader middleware Feat: Quickstart using the middleware Dec 16, 2024
@DavidMinarsch DavidMinarsch changed the title Feat: Quickstart using the middleware DO NOT MERGE Feat: Quickstart using the middleware Dec 17, 2024
@DavidMinarsch DavidMinarsch marked this pull request as draft December 17, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMinarsch DavidMinarsch DavidMinarsch left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OjusWiZard @DavidMinarsch