Introduce websocket protocol #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
reviewed
May 31, 2023
There was a problem hiding this comment.
The header is missing.
Adamantios
reviewed
May 31, 2023
There was a problem hiding this comment.
The recv part confused me. Shouldn't there be a way to check for data only with the connection id?
Update contract subscription skill to use new connection and websocket client skill
Introduce websocket subscription skill and update the websocket client connection to use subscription model
0xArdi
reviewed
Jun 26, 2023
|
|
||
| async def subscribe(self, url: str) -> "WebsocketSubcription": | ||
| """Subscribe to websocket.""" | ||
| # TODO: make these configurable |
There was a problem hiding this comment.
you are addressing this in a future version I assume?
0xArdi
approved these changes
Jun 26, 2023
|
This looks cool |
# Conflicts: # packages/packages.json # packages/valory/agents/mech/aea-config.yaml # packages/valory/connections/websocket_client/connection.py # packages/valory/connections/websocket_client/connection.yaml # packages/valory/contracts/agent_mech/contract.py # packages/valory/skills/contract_subscription/dialogues.py # packages/valory/skills/contract_subscription/handlers.py # packages/valory/skills/contract_subscription/skill.yaml # packages/valory/skills/mech_abci/skill.yaml # packages/valory/skills/reset_pause_abci/skill.yaml
Adamantios
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.