Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nominate contract page #45

Merged
merged 49 commits into from
Jun 25, 2024
Merged

Add nominate contract page #45

merged 49 commits into from
Jun 25, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai commented Jun 24, 2024 •
edited
Loading

Proposed changes

Adds the switch network yellow button
Adds a page where the user can nominate a contract for voting on Govern (note: they only can add a contract for voting on Ethereum, so we need to switch the network if they are on the wrong one)

See the flow on the video

Screen.Recording.2024-06-24.at.18.16.02.mov

Other states:

Tx failed Switch network Connect the wallet Contract already nominated Contract not found
image image image image image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

mohandast52 and others added 30 commits June 20, 2024 19:37
@mohandast52
refactor: Update launch store to include my staking contracts
353d706
@mohandast52
refactor: Update import paths for components and hooks in autonolas-r…
2fa474b 
…egistry tests and common-util
@mohandast52
refactor: Remove unnecessary CSS padding in GlobalStyles.tsx
09b03a2
@mohandast52
feat: Add dummy data for my staking contracts in launch store
b86c423
@mohandast52
refactor: Update MyStakingContracts component to include loading stat…
88ff227 
…e and create contract functionality
@mohandast52
feat: Add MyStakingContracts/List component for displaying staking co…
6c111c3 
…ntracts
@mohandast52
refactor: Update URL constant for my-staking-contracts and add popove…
ddc3949 
…r for staking incentives
@mohandast52
feat: Add useGetMyStakingContracts hook for fetching staking contract…
d6a81c4 
…s (call with Tanya)
@mohandast52
refactor: Update clip-path attribute to clipPath in LogoSvg component
91de9fc
@mohandast52
chore: add hooks to fetch my staking contracts
716fedb
@mohandast52
refactor: Add ethers utility function for converting address to bytes32
c55ca7c
@mohandast52
refactor: Update MyStakingContracts List component to display a succe…
4341e8f 
…ss tag when a contract is nominated
@mohandast52
refactor: Update MyStakingContracts component to use GOVERN_URL inste…
cb815f5 
…ad of URL.myStakingContracts
@mohandast52
refactor: Add nominate contract functionality to MyStakingContracts L…
095e3ae 
…ist component
@mohandast52
refactor: Improve useGetMyStakingContractsMetadata hook to handle err…
0a45d9c 
…ors and filter out empty metadata
@mohandast52
chore: address Tanya's review comments
ea60f05
@mohandast52
refactor: Hide menu on certain pages in Layout component
1f8672e
@mohandast52
refactor: Update useGetMyStakingContractsMetadata hook to handle erro…
bfc737f 
…rs and filter out empty metadata
@mohandast52
refactor: Filter out null values in useGetMyStakingContracts and fix …
876e720 
…build fail
@mohandast52
refactor: Update useGetMyStakingContracts to use ChainId instead of S…
79077db 
…upportedChain
@mohandast52
refactor: Update useGetMyStakingContracts to use ChainId instead of S…
2b0accc 
…upportedChain
@mohandast52
chore: renames
b174b5e
Fix defining is nominated
b75b923
Add nominate tx
1cd801e
@mohandast52
conflict fixes
d131175
@mohandast52
chore: move useHandleRoute hook to _app.jsx
acd076b
@mohandast52
refactor: Remove unused import in web3.ts
13314e1
@mohandast52
refactor: Update import path for NominatedContract component
4c48a0a
@mohandast52
chore: Update NominatedContract component
faf7963
@mohandast52
refactor: Update NominatedContract component import path and move pre…
83aec77 
…sentational components
@Tanya-atatakai Tanya-atatakai changed the title Tanya/launch nominate contract Add nominate contract page Jun 24, 2024
mohandast52
mohandast52 reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apps/launch/common-util/functions/frontend-library.ts Outdated Show resolved Hide resolved
apps/launch/store/launch.ts Outdated Show resolved Hide resolved
apps/launch/hooks/useGetMyStakingContracts.ts Show resolved Hide resolved
apps/launch/components/NominateContract/utils.tsx Show resolved Hide resolved
@Tanya-atatakai Tanya-atatakai requested a review from dagacha June 25, 2024 14:47
dagacha
dagacha approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@dagacha dagacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to allow for further iterations - as requested

truemiller
truemiller approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@truemiller truemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are non-blocking, looks good otherwise

@mohandast52 mohandast52 merged commit 4110ae6 into main Jun 25, 2024
8 checks passed
@mohandast52 mohandast52 deleted the tanya/launch-nominate-contract branch June 25, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagacha dagacha dagacha approved these changes

@truemiller truemiller truemiller approved these changes

@mohandast52 mohandast52 mohandast52 approved these changes

@oaksprout oaksprout Awaiting requested review from oaksprout oaksprout is a code owner

@DavidMinarsch DavidMinarsch Awaiting requested review from DavidMinarsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tanya-atatakai @mohandast52 @truemiller @dagacha