Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit fixes #19

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Audit fixes #19

merged 3 commits into from
Mar 26, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

Proposed changes

image

Fixes

Removes max amount

  1. for pre registration step uses amountToApprove: 1 for checkAndApproveToken
  2. for active registration step uses amountToApprove: total bounds amount for checkAndApproveToken

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Mar 25, 2024

Someone is attempting to deploy this pull request to the autonolas Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@Tanya-atatakai Tanya-atatakai requested review from mohandast52 and kupermind and removed request for mohandast52 March 25, 2024 18:18
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autonolas-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:56pm
tokenomics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:56pm

await checkAndApproveToken({ account, chainId, serviceId, amountToApprove: ethers.utils.parseUnits(
`${totalBonds}`,
'ether',
)});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might need to format the page - right click and format document

@Tanya-atatakai Tanya-atatakai merged commit 24542c4 into main Mar 26, 2024
2 of 4 checks passed
@Tanya-atatakai Tanya-atatakai deleted the fix/audit-changes branch March 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants