Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(launch) fix: Rewards per second #127

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Oct 30, 2024

Proposed changes

The “Rewards per second” field was having issues with large decimal numbers, so changed it from “InputNumber” to “Input” to accommodate all values. This also includes validation to ensure only numbers are accepted and only one decimal place is allowed.

Fixes

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bond ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:16pm
govern ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:16pm
launch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:16pm
operate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:16pm
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 5:16pm

@mohandast52 mohandast52 self-assigned this Oct 30, 2024
@mohandast52 mohandast52 added the bug Something isn't working label Oct 30, 2024
@vercel vercel bot temporarily deployed to Preview – registry October 30, 2024 15:15 Inactive
@vercel vercel bot temporarily deployed to Preview – govern October 30, 2024 15:16 Inactive
@vercel vercel bot temporarily deployed to Preview – bond October 30, 2024 15:16 Inactive
@mohandast52 mohandast52 merged commit 6204d48 into main Nov 4, 2024
8 checks passed
@mohandast52 mohandast52 deleted the mohan/check-launch-input branch November 4, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants