Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(registry) fix: add gas estimation to creating agent and component #108

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

Fixes

Sometimes minting agent or component shows too big gas amount. Added gas estimation
Screenshot 2024-10-01 at 18 36 25

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 2:46pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
bond ⬜️ Ignored (Inspect) Oct 1, 2024 2:46pm
govern ⬜️ Ignored (Inspect) Oct 1, 2024 2:46pm
launch ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:46pm
operate ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:46pm

@Tanya-atatakai Tanya-atatakai merged commit 84158ce into main Oct 1, 2024
8 checks passed
@truemiller
Copy link
Collaborator

contract interactions should run gas estimation automatically 🤔

wondering if there's some point where interaction is invalid and wallet is estimating reversion? hopefully this fixes 🤞

@Tanya-atatakai Tanya-atatakai deleted the tanya/registry-gas-fix branch October 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants