test: more tests #67
Merged
test: more tests #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Dec 27, 2024
kupermind
commented
- Adding more tests.
kupermind
commented
Dec 27, 2024
Comment on lines
+227
to
+228
| // If balance is 1, the marketplace fee is still 1, and thus mech payment will be zero | ||
| if (balance < 2) { |
There was a problem hiding this comment.
A small logical refactor here
kupermind
commented
Dec 27, 2024
| @@ -223,7 +223,7 @@ abstract contract OlasMech is Mech, IErrorsMech, ImmutableStorage { | |||
| function requestFromMarketplace(address requester, bytes memory data, uint256 requestId) external { | |||
| // Check for marketplace access | |||
| if (msg.sender != mechMarketplace) { | |||
| revert MarketplaceNotAuthorized(msg.sender); | |||
| revert MarketplaceOnly(msg.sender, mechMarketplace); | |||
There was a problem hiding this comment.
Just to be consistent with the rest
Sfgangloff
approved these changes
Dec 27, 2024
DavidMinarsch
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.