Internal audit reward #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
77ph
commented
Jun 6, 2023
77ph
commented
- Internal audit focused on swap
added 2 commits
June 5, 2023 15:14
0xArdi
reviewed
Jun 6, 2023
Comment on lines
+12
to
+21
| def _get_gas_spent(self) -> Generator[None, None, str]: | ||
| # we start from the block the block in which the last withdraw event happened, or from the first block if we have | ||
| # never withdrawn | ||
| from_block = ( | ||
| 0 | ||
| if latest_withdraw_event == self._NO_EVENT | ||
| else latest_withdraw_event["block_number"] | ||
| ) | ||
| # we end at the block in which the last unbonding event happened | ||
| to_block = latest_unbonding_event["block_number"] |
0xArdi
reviewed
Jun 6, 2023
Comment on lines
+89
to
+90
| expected = pool.get_dy(0, 1, 10**18) * 0.99 | ||
| pool.exchange(0, 1, 10**18, expected, {'from': alice}) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.