Increase fee to 15bps and reduce minimum option duration to 1 min #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ci-across-active-protocol-repos 🔧 Standardize CI across active protocol repos
…erministic-deploys Dry run deterministic deploys
VAL-848 Valorem Clear fees and duration
The minimum option duration must be 1 minute, the fee basis points on notional must be 15, fees must only be charged on exercise, and on the underlying at redemption. |
0xAlcibiades
requested review from
neodaoist,
plaird523,
dalechyn and
megsdevs
dalechyn
suggested changes
Aug 22, 2023
2 tasks
|
Pipeline broken by foundry bug: foundry-rs/foundry#5697 - awaiting fix or pinning previous version before merge. |
0xAlcibiades
changed the title
0xAlcibiades
deleted the
alcibiades/val-848-valorem-clear-fees-and-duration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.