-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more actions token bottom sheet #4309
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0df5aac
feat: more actions token bottom sheet
MuckT 1b424df
Merge branch 'main' into tomm/act-917
MuckT d60da9f
fix: make android ripple extend to edge of touchable
MuckT 38281f5
refactor: use bottom sheet without ref
MuckT a359f93
fix: remove stray ref
MuckT 2cfe2f1
test: render for more actions bottom sheet
MuckT 59ba965
chore: update root state schema
MuckT 4e20eb1
Merge branch 'main' into tomm/act-917
MuckT 998890e
Merge branch 'main' into tomm/act-917
MuckT 6a05b48
test(more-actions): add test for analytics and send action navigation
MuckT 7ed8cf2
test(more-actions): test analytics and navigation for each action
MuckT 71a2696
Merge branch 'main' into tomm/act-917
MuckT 4e65ff0
Merge branch 'main' into tomm/act-917
MuckT 89ccaa0
Merge branch 'main' into tomm/act-917
MuckT 331e75f
refactor: use bottom sheet with ref
MuckT 8e56941
docs: add linear ticket number to todo comment
MuckT dd45537
Merge branch 'main' into tomm/act-917
MuckT d001e30
chore: implement pr feedback
MuckT 2015927
Merge branch 'main' into tomm/act-917
MuckT 79f38df
Merge branch 'main' into tomm/act-917
MuckT a01cb03
style: navigation props
MuckT f75d895
test: remove unused provider and store
MuckT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's an open question on where Withdraw should navigate right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still an open question @nityarao responded in Figma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment on the thread. This can be fixed in a follow up PR