Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(assets): add chart to token details screen #4283

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

satish-ravi
Copy link
Contributor

@satish-ravi satish-ravi commented Oct 8, 2023

Description

Reuses the existing celo chart component to display chart for CELO on the token details page.

Test plan

Token details Celo
iOS
Android

Related issues

Backwards compatibility

Yes

Base automatically changed from satish/act-915 to main October 10, 2023 02:58
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #4283 (742779f) into main (7207250) will increase coverage by 0.00%.
The diff coverage is 93.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4283   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files         711      711           
  Lines       26178    26185    +7     
  Branches     3401     3405    +4     
=======================================
+ Hits        21995    22002    +7     
  Misses       4117     4117           
  Partials       66       66           
Files Coverage Δ
src/tokens/TokenDetails.tsx 85.14% <100.00%> (+0.45%) ⬆️
test/values.ts 100.00% <ø> (ø)
src/exchange/CeloGoldHistoryChart.tsx 92.79% <91.66%> (+0.26%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7207250...742779f. Read the comment docs.

@satish-ravi satish-ravi merged commit 97088fc into main Oct 10, 2023
15 checks passed
@satish-ravi satish-ravi deleted the satish/act-916 branch October 10, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants