feat(transfers): Remove old feature flag, support tokenId in transfer feed and CICO #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jophish
changed the title
jophish
commented
Oct 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #4275 +/- ##
==========================================
+ Coverage 84.02% 84.05% +0.02%
==========================================
Files 711 712 +1
Lines 26194 26233 +39
Branches 3408 3410 +2
==========================================
+ Hits 22010 22049 +39
Misses 4118 4118
Partials 66 66
Continue to review full report in Codecov by Sentry.
|
cajubelt
reviewed
Oct 6, 2023
cajubelt
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up an old hacky feature flag we had laying around, and in the process adds support for native tokens to appear correctly in the transfer feed. This also has the effect of refactoring some of our CICO code to support tokenIds as well, in order to use the new
TokenDisplaycomponent in the case ofETHbeing selected.Test plan
Unit and manual tested. See video below for ETH information showing up where it previously was not (namely: transfer feed items, transfer feed details page, CICO header balance). The second video shows the existing behavior, where ETH is kinda broken all over the place.
eth-in-app-2023-10-06_14.35.29.mp4
eth-broken-2023-10-06_14.38.10.mp4
Related issues
N/A
Backwards compatibility
Yes.