Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove merchant payments feature #4272

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

kathaypacific
Copy link
Collaborator

Description

Essentially this PR reverts #3376.

I've also removed the translations because I think it is unlikely that we will want to push over the air translations for this feature.

Test plan

n/a

Related issues

Backwards compatibility

Y

@kathaypacific kathaypacific changed the title Kathy/remove merchant payments chore: remove merchant payments feature Oct 6, 2023
@emerge-tools
Copy link

emerge-tools bot commented Oct 6, 2023

1 build decreased size

Name Version Download Change Install Change
Celo (test) 1.69.0 (134) 26.8 MB ⬇️ 123.4 kB (-0.46%) 64.1 MB ⬇️ 229.4 kB (-0.36%)

Celo (test) 1.69.0 (134)

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬇️ 229.4 kB (-0.36%)
Total download size change: ⬇️ 123.4 kB (-0.46%)

Largest size changes

Item Install Size Change
main.jsbundle ⬇️ -229.4 kB

🛸 Powered by Emerge Tools

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels good!! ✂️ 🚀

@kathaypacific kathaypacific enabled auto-merge (squash) October 6, 2023 12:52
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #4272 (e837eb5) into main (c0c5436) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4272      +/-   ##
==========================================
+ Coverage   83.84%   83.97%   +0.12%     
==========================================
  Files         710      705       -5     
  Lines       26210    26001     -209     
  Branches     3419     3385      -34     
==========================================
- Hits        21977    21834     -143     
+ Misses       4166     4102      -64     
+ Partials       67       65       -2     
Files Coverage Δ
src/app/reducers.ts 20.83% <ø> (ø)
src/app/saga.ts 73.12% <ø> (+0.20%) ⬆️
src/app/selectors.ts 94.73% <ø> (-0.10%) ⬇️
src/firebase/firebase.ts 37.56% <ø> (ø)
src/firebase/remoteConfigValuesDefaults.ts 100.00% <ø> (ø)
src/navigator/Screens.tsx 100.00% <ø> (ø)
src/qrcode/utils.ts 79.48% <ø> (+9.38%) ⬆️
src/redux/migrations.ts 98.05% <100.00%> (ø)
src/redux/store.ts 79.36% <ø> (ø)
test/schemas.ts 90.29% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c5436...e837eb5. Read the comment docs.

@kathaypacific kathaypacific merged commit ee64574 into main Oct 6, 2023
15 checks passed
@kathaypacific kathaypacific deleted the kathy/remove-merchant-payments branch October 6, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants