Skip to content

Commit

Permalink
chore(ci): accept all Android licenses (#6086)
Browse files Browse the repository at this point in the history
### Description

Add an explicit step to accept all `sdkmanager`
[licenses](https://developer.android.com/tools/sdkmanager#accept-licenses),
so the subsequent tooling installations do not fail.

For instance, emulator installation with Android 28 will not fail like
it did in this action:

https://github.com/valora-inc/wallet/actions/runs/10996847867/job/30569279072?pr=6031

### Test plan

CI succeeds

### Related issues

Related to RET-1194

### Backwards compatibility

NA

### Network scalability

NA
  • Loading branch information
bakoushin authored Sep 24, 2024
1 parent 62bef57 commit b39dbf8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/e2e-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,12 @@ jobs:
# Temporarily disable checking for EPIPE error and use yes to accept all licenses
set +o pipefail
yes | sdkmanager "platform-tools" "platforms;android-${{ env.ANDROID_COMPILE_SDK_VERSION }}"
yes | sdkmanager --licenses
set -o pipefail
# Install Android SDK
sdkmanager "platform-tools" "platforms;android-${{ env.ANDROID_COMPILE_SDK_VERSION }}"
# Install Ninja
sudo apt-get install ninja-build
Expand Down

0 comments on commit b39dbf8

Please sign in to comment.