Respond to comments

valora-inc · Oct 6, 2023 · a4a0826 · a4a0826
1 parent 2fc53e0
commit a4a0826
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 18 deletions.
diff --git a/src/components/TokenBalance.test.tsx b/src/components/TokenBalance.test.tsx
@@ -49,7 +49,7 @@ const defaultStore = {
 
 jest.mocked(getFeatureGate).mockReturnValue(true)
 jest.mocked(getDynamicConfigParams).mockReturnValue({
-  showBalances: [NetworkId['celo-alfajores'], NetworkId['ethereum-sepolia']],
+  showBalances: [NetworkId['celo-alfajores']],
 })
 
 describe('FiatExchangeTokenBalance and HomeTokenBalance', () => {

diff --git a/src/fiatExchanges/FiatExchangeCurrency.test.tsx b/src/fiatExchanges/FiatExchangeCurrency.test.tsx
@@ -13,7 +13,7 @@ import { getDynamicConfigParams } from 'src/statsig'
 jest.mock('src/statsig', () => ({
   getDynamicConfigParams: jest.fn(() => {
     return {
-      enableCico: ['celo-alfajores'],
+      showCico: ['celo-alfajores'],
     }
   }),
 }))
@@ -84,7 +84,7 @@ describe('FiatExchangeCurrency', () => {
   })
   it('ETH Flow', () => {
     jest.mocked(getDynamicConfigParams).mockReturnValueOnce({
-      enableCico: [NetworkId['celo-alfajores'], NetworkId['ethereum-sepolia']],
+      showCico: [NetworkId['celo-alfajores'], NetworkId['ethereum-sepolia']],
     })
     const store = createMockStore({})
     const tree = render(

diff --git a/src/fiatExchanges/FiatExchangeCurrency.tsx b/src/fiatExchanges/FiatExchangeCurrency.tsx
@@ -110,7 +110,7 @@ function FiatExchangeCurrency({ route, navigation }: Props) {
   // TODO: Update this to actually respect all possible networkIds correctly
   const showEth = getDynamicConfigParams(
     DynamicConfigs[StatsigDynamicConfigs.MULTI_CHAIN_FEATURES]
-  ).enableCico.includes(networkConfig.networkToNetworkId[Network.Ethereum])
+  ).showCico.includes(networkConfig.networkToNetworkId[Network.Ethereum])
 
   // Fetch FiatConnect providers silently in the background early in the CICO funnel
   useEffect(() => {

diff --git a/src/home/WalletHome.test.tsx b/src/home/WalletHome.test.tsx
@@ -130,7 +130,6 @@ jest.mock('src/statsig', () => ({
   })),
   getFeatureGate: jest.fn().mockReturnValue(false),
   getDynamicConfigParams: jest.fn(() => ({
-    enableCico: ['celo-alfajores'],
     showBalances: ['celo-alfajores'],
     showTransfers: ['celo-alfajores'],
   })),

diff --git a/src/navigator/DrawerNavigator.test.tsx b/src/navigator/DrawerNavigator.test.tsx
@@ -11,9 +11,7 @@ jest.mock('src/statsig', () => ({
   getExperimentParams: jest.fn(),
   getFeatureGate: jest.fn().mockReturnValue(false),
   getDynamicConfigParams: jest.fn(() => ({
-    enableCico: ['celo-alfajores'],
     showBalances: ['celo-alfajores'],
-    showTransfers: ['celo-alfajores'],
   })),
 }))
 

diff --git a/src/statsig/constants.ts b/src/statsig/constants.ts
@@ -92,7 +92,7 @@ export const DynamicConfigs = {
   [StatsigDynamicConfigs.MULTI_CHAIN_FEATURES]: {
     configName: StatsigDynamicConfigs.MULTI_CHAIN_FEATURES,
     defaultValues: {
-      enableCico: [networkConfig.defaultNetworkId],
+      showCico: [networkConfig.defaultNetworkId],
       showBalances: [networkConfig.defaultNetworkId],
       showTransfers: [networkConfig.defaultNetworkId],
     },

diff --git a/src/tokens/Assets.test.tsx b/src/tokens/Assets.test.tsx
@@ -22,9 +22,7 @@ jest.mock('src/statsig', () => {
   return {
     getFeatureGate: jest.fn(),
     getDynamicConfigParams: jest.fn(() => ({
-      enableCico: ['celo-alfajores'],
       showBalances: ['celo-alfajores'],
-      showTransfers: ['celo-alfajores'],
     })),
   }
 })

diff --git a/src/tokens/TokenBalances.test.tsx b/src/tokens/TokenBalances.test.tsx
@@ -5,7 +5,7 @@ import { HomeEvents } from 'src/analytics/Events'
 import ValoraAnalytics from 'src/analytics/ValoraAnalytics'
 import { navigate } from 'src/navigator/NavigationService'
 import { Screens } from 'src/navigator/Screens'
-import { getDynamicConfigParams, getFeatureGate } from 'src/statsig'
+import { getFeatureGate } from 'src/statsig'
 import TokenBalancesScreen from 'src/tokens/TokenBalances'
 import { ONE_DAY_IN_MILLIS } from 'src/utils/time'
 import networkConfig from 'src/web3/networkConfig'
@@ -191,9 +191,6 @@ describe('TokenBalancesScreen', () => {
   })
 
   it('renders the correct components when there are positions', () => {
-    jest.mocked(getDynamicConfigParams).mockReturnValue({
-      showBalances: [NetworkId['celo-alfajores'], NetworkId['ethereum-sepolia']],
-    })
     jest.mocked(getFeatureGate).mockReturnValue(true)
     const store = createMockStore(storeWithPositions)
 
@@ -214,9 +211,6 @@ describe('TokenBalancesScreen', () => {
   })
 
   it('renders the correct information in positions', () => {
-    jest.mocked(getDynamicConfigParams).mockReturnValue({
-      showBalances: [NetworkId['celo-alfajores'], NetworkId['ethereum-sepolia']],
-    })
     jest.mocked(getFeatureGate).mockReturnValue(true)
     const store = createMockStore(storeWithPositions)
 

diff --git a/src/transactions/feed/TransactionFeed.test.tsx b/src/transactions/feed/TransactionFeed.test.tsx
@@ -19,7 +19,7 @@ import { mockCusdAddress } from 'test/values'
 jest.mock('src/statsig', () => ({
   getFeatureGate: jest.fn(() => false),
   getDynamicConfigParams: jest.fn(() => ({
-    enableCico: ['celo-alfajores'],
+    showCico: ['celo-alfajores'],
     showBalances: ['celo-alfajores'],
     showTransfers: ['celo-alfajores'],
   })),