Skip to content

Commit

Permalink
ci: ignore emergetools errors (#5944)
Browse files Browse the repository at this point in the history
### Description

The new Emergetools indie plan is limited in the number of builds.
Ignore errors for now until we decide what we want to do with it.

### Test plan

- Tests pass

### Related issues

N/A

### Backwards compatibility

Yes

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [x] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)
  • Loading branch information
jeanregisser authored Sep 9, 2024
1 parent 38c5b7b commit 6e7710c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 7 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/e2e-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ jobs:
if: |
env.SECRETS_AVAILABLE
&& (github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'merge_group')
# This step is not critical, so we continue on error
continue-on-error: true
run: yarn ts-node .github/scripts/uploadE2eBuildToEmerge.ts
env:
EMERGE_API_TOKEN: ${{ steps.google-secrets.outputs.EMERGE_API_TOKEN }}
Expand Down
19 changes: 12 additions & 7 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,18 @@ end

def fastlane_emerge(environment:, file_path:)
# Note: this requires the EMERGE_API_TOKEN env var to be set
emerge(
file_path: file_path,
repo_name: "valora-inc/wallet",
sha: `git rev-parse HEAD`.strip,
branch: `git branch --show-current`.strip,
tag: environment,
)
begin
emerge(
file_path: file_path,
repo_name: "valora-inc/wallet",
sha: `git rev-parse HEAD`.strip,
branch: `git branch --show-current`.strip,
tag: environment,
)
rescue => ex
# Don't fail the build if Emerge fails (e.g. 429 or 500)
UI.important("Ignoring upload error to Emerge: #{ex}")
end
end

platform :android do
Expand Down

0 comments on commit 6e7710c

Please sign in to comment.