More rebranding #606
Merged
More rebranding #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd error replies Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #606 +/- ##
=========================================
Coverage 70.24% 70.24%
=========================================
Files 110 110
Lines 59993 59993
=========================================
+ Hits 42140 42145 +5
+ Misses 17853 17848 -5
|
PingXie
approved these changes
Jun 6, 2024
| @@ -3081,7 +3081,7 @@ int rdbLoadRioWithLoadingCtx(rio *rdb, int rdbflags, rdbSaveInfo *rsi, rdbLoadin | |||
| } else if (!strcasecmp(auxkey->ptr, "redis-ver")) { | |||
| serverLog(LL_NOTICE, "Loading RDB produced by Redis version %s", (char *)auxval->ptr); | |||
There was a problem hiding this comment.
Suggested change
| serverLog(LL_NOTICE, "Loading RDB produced by Redis version %s", (char *)auxval->ptr); | |
| serverLog(LL_NOTICE, "Loading RDB produced by Valkey version %s", (char *)auxval->ptr); |
There was a problem hiding this comment.
Actually, this log entry is for the field "redis-ver", meaning we're loading an RDB file produced by Redis. We have another field "valkey-ver" too that's checked in the else-if below.
advaMosh
pushed a commit
to advaMosh/valkey
that referenced
this pull request
Jun 10, 2024
More rebranding of * Log messages (valkey-io#252) * The DENIED error reply * Internal function names and comments, mainly Lua API --------- Signed-off-by: Viktor Söderqvist <[email protected]> Signed-off-by: Adva Moshkovitz <[email protected]>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Jun 10, 2024
More rebranding of * Log messages (valkey-io#252) * The DENIED error reply * Internal function names and comments, mainly Lua API --------- Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More rebranding of