Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a single validation function around the service_uri #28

Closed
wants to merge 26 commits into from

Conversation

ahmedsobeh
Copy link
Collaborator

@ahmedsobeh ahmedsobeh commented Jun 28, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Created url_parser and removed duplication of parse_url. This PR resolves issue #25

I created a url_parser module and added it to the parsers folder. I then used this module in both connection modules (the normal one and the asyncio one) and updated the tests accordingly.

@ahmedsobeh ahmedsobeh marked this pull request as draft June 28, 2024 14:39
Signed-off-by: ahmedsobeh <[email protected]>
Signed-off-by: ahmedsobeh <[email protected]>
Signed-off-by: ahmedsobeh <[email protected]>
Signed-off-by: ahmedsobeh <[email protected]>
Signed-off-by: ahmedsobeh <[email protected]>
Signed-off-by: ahmedsobeh <[email protected]>
Signed-off-by: ahmedsobeh <[email protected]>
Signed-off-by: ahmedsobeh <[email protected]>
@ahmedsobeh ahmedsobeh marked this pull request as ready for review June 30, 2024 09:22
@ahmedsobeh ahmedsobeh closed this Jun 30, 2024
@ahmedsobeh ahmedsobeh deleted the issue-25 branch June 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant