Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.1.0b6 #20

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Version 5.1.0b6 #20

merged 10 commits into from
Jun 14, 2024

Conversation

aiven-sal
Copy link
Member

Import some useful commits from redis-py v5.1.0b6 and bump the version

@aiven-sal aiven-sal marked this pull request as draft June 14, 2024 09:25
@aiven-sal aiven-sal force-pushed the aiven-sal/changes_for_b6 branch 2 times, most recently from 2c6c568 to e48049d Compare June 14, 2024 11:35
aiven-sal and others added 10 commits June 14, 2024 13:35
Signed-off-by: Salvatore Mesoraca <[email protected]>
Pyright treats explicit and implicit `Any` differently, with implicit `Any` being treated as `Unknown`. Pyright raised a warning indicating an unknown member type for 'Awaitable' when used in 'ResponseT'. Using the `incr` method as an example, the warning is:

```
"warning: Type of 'incr' is partially unknown
 Type of 'incr' is '(name: bytes | str | memoryview, amount: int = 1) -> (Awaitable[Unknown] | Any)' (reportUnknownMemberType)"
```

By explicitly specifying 'Awaitable[Any]' in the union for 'ResponseT', this resolves the ambiguity about the member type.

Signed-off-by: Salvatore Mesoraca <[email protected]>
The address_remap callback received a tuple with the host and the port.
Make this clear in the typing hints.

Signed-off-by: Salvatore Mesoraca <[email protected]>
Run pyupgrade for 3.8.

Signed-off-by: Salvatore Mesoraca <[email protected]>
When parsing the response of FT.PROFILE, handle the cases when the
nested items are either not lists, or empty lists, or lists with a
single item.

Co-authored-by: Gabriel Erzse <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
Make the parsing of memory stats response more robust, to not break on
changes that will be added to the Redis server.

Also make a test related to client kill by maxage more resilient.

Co-authored-by: Gabriel Erzse <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
Add type hints to backoff.py

Signed-off-by: Salvatore Mesoraca <[email protected]>
If the INFO response contains a single `a=b` value for any of the keys,
that must also be parsed into a dictionary.

Fixes #3262

Co-authored-by: Gabriel Erzse <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
Support hash field expiration commands that become available with
Redis 7.4.

Adapt some tests to match recent server-side changes. Update tests
related to memory stats. Make CLIENT KILL test not run with cluster.

---------

Co-authored-by: Gabriel Erzse <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
@aiven-sal aiven-sal force-pushed the aiven-sal/changes_for_b6 branch from e48049d to 9e29e5e Compare June 14, 2024 11:36
@aiven-sal aiven-sal marked this pull request as ready for review June 14, 2024 12:25
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aiven-sal aiven-sal merged commit a1053d7 into main Jun 14, 2024
49 checks passed
@aiven-sal aiven-sal deleted the aiven-sal/changes_for_b6 branch June 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants