-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s/redis/valkey/ single commit with fixes #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the pull request, Salvatore! Great job!
I've left some of the nitpicks I managed to get during the review. I believe, though, that the only types that actually have to be changed before merge are:
- Automatic changes in words "storedist" and "redistribution"
- Links to the old issues
- An unchanged link to redis.io
Everything else (including multiple references to the "old valkey version" and "old valkey-py version") can be addressed later.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Most issues should be fixed. If I put a 👍 under your comment, please check if the solution is satisfying and resolve the conversation or comment again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the comments have been fixed, but I still found a couple of places that should be changed before we merge this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks again for the great job!
I'm pretty sure I overlooked something.
But all tests pass locally.
I don't expect the CI to work 100% yet, but we should fix it before we merge.