Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 131: Fixes Flaky test by increasing timeout to 1s #136

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

paulorochaoliveira
Copy link

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

The thread's join has a timeout that is too short (0.1) and sometimes the test fails, so I'm Increasing it to 1 second to avoid failing.

@mkmkme
Copy link
Collaborator

mkmkme commented Dec 4, 2024

Hey Paulo, thanks for your contribution!

Regardless of the code change, I'd like to request some changes on the commit itself.

  1. Could you please replace Issue 131: in your commit message with fixes #131 on a separate line of the commit message?
  2. Could you please set your e-mail via git config --global user.email <your email> so that the Signed-off-by: line would have a proper e-mail address instead of [email protected]?

Thanks!

@paulorochaoliveira
Copy link
Author

Hi @mkmkme! I'm happy to contribute.
I just pushed the changes recommended.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (9c67ddf) to head (7a66661).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files         130      130           
  Lines       33907    33907           
=======================================
  Hits        25837    25837           
  Misses       8070     8070           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-sal aiven-sal enabled auto-merge December 4, 2024 17:10
@aiven-sal aiven-sal merged commit 4f7e880 into valkey-io:main Dec 4, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants