Skip to content

Commit

Permalink
Depend on hiredis < 3.0.0
Browse files Browse the repository at this point in the history
hiredis 3.0.0 breaks compatibility with valkey-py.
This is just a temporary fix until #32 is ready.

Signed-off-by: Salvatore Mesoraca <[email protected]>
  • Loading branch information
aiven-sal committed Jul 22, 2024
1 parent 2b86482 commit 500bb82
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
pip install -r requirements.txt
pip install -r dev_requirements.txt
if [ "${{matrix.connection-type}}" == "hiredis" ]; then
pip install hiredis
pip install "hiredis<3.0.0"
fi
invoke devenv
sleep 10 # time to settle
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
pip install -r requirements.txt
pip install -r dev_requirements.txt
if [ "${{matrix.connection-type}}" == "hiredis" ]; then
pip install hiredis
pip install "hiredis<3.0.0"
fi
invoke devenv
sleep 10 # time to settle
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"Programming Language :: Python :: Implementation :: PyPy",
],
extras_require={
"hiredis": ["hiredis>=1.0.0"],
"hiredis": ["hiredis >=1.0.0, <3.0.0"],
"ocsp": ["cryptography>=36.0.1", "pyopenssl==20.0.1", "requests>=2.26.0"],
},
)

0 comments on commit 500bb82

Please sign in to comment.