Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy #623

Merged
merged 9 commits into from
Jun 21, 2024
Merged

fix clippy #623

merged 9 commits into from
Jun 21, 2024

Conversation

JackCrumpLeys
Copy link
Contributor

make clippy happy.

@JackCrumpLeys JackCrumpLeys mentioned this pull request Jun 19, 2024
@JackCrumpLeys JackCrumpLeys marked this pull request as draft June 19, 2024 21:43
@JackCrumpLeys
Copy link
Contributor Author

I need to do a lil more

@JackCrumpLeys
Copy link
Contributor Author

ive done what I can as generated code is failing CI and I dont wanna fix that rn

Copy link
Member

@rj00a rj00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish there was a way to disable the pub -> pub(crate) lint for binaries.

@JackCrumpLeys JackCrumpLeys marked this pull request as ready for review June 21, 2024 02:56
@JackCrumpLeys
Copy link
Contributor Author

@rj00a I'm gonna work on the dep update now so can we get this merged? I know it doesn't solve all but I can do the generated code after updating deps.

@rj00a rj00a merged commit 646a76e into valence-rs:main Jun 21, 2024
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants