Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard div_cell #547

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Use standard div_cell #547

merged 2 commits into from
Oct 8, 2023

Conversation

SelfMadeSystem
Copy link
Contributor

Objective

Solution

Rust 1.73.0 stabilized div_ceil for unsigned integers.

  • Replaces num_integer::div_ceil with the standard div_ceil.
  • Removes num-integer crate as a dependency because it is no longer used.

dyc3
dyc3 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dyc3 dyc3 enabled auto-merge (squash) October 8, 2023 15:21
@dyc3 dyc3 merged commit b099ebf into valence-rs:main Oct 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use standard div_ceil
2 participants
@SelfMadeSystem @dyc3