Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nondeterminism from tags extractor #545

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Remove nondeterminism from tags extractor #545

merged 2 commits into from
Oct 6, 2023

Conversation

rj00a
Copy link
Member

@rj00a rj00a commented Oct 6, 2023

Objective

Fix the issue where running the tags extractor multiple times produces different outputs.

Solution

  • Replace HashMap with TreeMap to make iteration consistent.
  • Add RegistryKeyComparator because registry keys are not Comparable.

@rj00a rj00a merged commit b8ac380 into main Oct 6, 2023
11 checks passed
@rj00a rj00a deleted the tags-extractor-fix branch October 6, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rj00a @dyc3