Make player health 20.0 by default #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
approved these changes
Aug 25, 2023
|
The CI failures are unrelated. |
rj00a
requested changes
Aug 25, 2023
There was a problem hiding this comment.
This is caused by #359 (comment). As a result, there are many other places where default values are incorrect.
If we must have a temp fix now, we should edit the extracted JSON file that has the default health value instead.
|
In that case, let's close this and open an issue for it instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When testing making a minigame example, I noticed the player always spawned with 6 health, which is the default for living entities in Valence.
It would also cause a desync between the client and server, because the client implies that it has 20.0 health upon spawning.