Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extractor output is non-determinisic. #359

Open
dyc3 opened this issue Jun 8, 2023 · 1 comment
Open

Extractor output is non-determinisic. #359

dyc3 opened this issue Jun 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@dyc3
Copy link
Collaborator

dyc3 commented Jun 8, 2023

Valence Version

6338fc6

What You Did

Run the extractor

What Went Wrong

Running the extractor does not produce exactly the same output every time. The overall structure will be the same, but fields and items in arrays may be in different orders.

This causes very messy diffs when Minecraft updates, or when a new extractor is added.

Additional Information

@dyc3 dyc3 added bug Something isn't working low priority Other issues are more important labels Jun 8, 2023
@rj00a
Copy link
Member

rj00a commented Jun 8, 2023

The problem is caused by an incorrect assumption. The extractor assumes that the default value for a particular tracked data field is the same across entity classes that inherit the field, but this is incorrect. The output format of the extractor will have to be changed along with the entity code generator in valence_entity.

Rather than having one system per tracked data, there needs to be one system per entity archetype.

@rj00a rj00a mentioned this issue Jun 8, 2023
56 tasks
@rj00a rj00a removed the low priority Other issues are more important label Aug 25, 2023
@rj00a rj00a linked a pull request Feb 11, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants