Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19/WAKU2-LIGHTPUSH: Update #112

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

19/WAKU2-LIGHTPUSH: Update #112

wants to merge 5 commits into from

Conversation

jimstir
Copy link
Collaborator

@jimstir jimstir commented Nov 21, 2024

Updating the 19/WAKU2-LIGHTPUSH rfc. Waku specs repo has a new rfc becuase the current specification is under specified. Information from that update is included with some changes. Also introduced the term edge nodes in this update.

- or perform another requested service.
`Services beyond [11/WAKU2-RELAY](/waku/standards/core/11/relay.md) are yet to be defined.`

Depending on the network configuration, the lightpush client may not need to provide `pubsub_topic`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a light node (edge node) and a service node be considered a lightpush client?

Copy link
Contributor

@jm-clius jm-clius Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within the context of lightpush and other req-resp protocols the protocol agents are always client and service node ("server" is sometimes used though somewhat less accurate IMO). I would stay away from "light node"/"edge node" within the context of req-resp protocol specifications. I think it's OK to use these terms in the motivation/background part only to explain why some nodes may choose to act as lightpush client. Edge nodes would typically prefer client mode, though these nodes all exist on a continuum of resource usage. In other words, "lightpush client" would be correct in this specific context as it refers to protocol behaviour.

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having reviewed in detail, I'm wondering if this update is premature? Waku specs repo indeed has a new version of the lightpush spec as experimental improvement, but I would suggest that the implementation and deployment reach some level of maturity before we replace the existing RFC (as this one is already in draft and matches the implementation). Both versions of the protocol will be supported for a while @NagyZoltanPeter can comment on maturity of the "new" protocol implementation. Once most clients have switched over, we can deprecate the old lightpush version - both the RFC and the implementation.

@NagyZoltanPeter
Copy link
Collaborator

Without having reviewed in detail, I'm wondering if this update is premature? Waku specs repo indeed has a new version of the lightpush spec as experimental improvement, but I would suggest that the implementation and deployment reach some level of maturity before we replace the existing RFC (as this one is already in draft and matches the implementation). Both versions of the protocol will be supported for a while @NagyZoltanPeter can comment on maturity of the "new" protocol implementation. Once most clients have switched over, we can deprecate the old lightpush version - both the RFC and the implementation.

Thanks @jm-clius, yes. new redesigned v2 of lightpush protocol is under development, spec available here: https://github.com/waku-org/specs/blob/master/standards/core/lightpush.md
cc: @jimstir, of course any comments are welcome.

@NagyZoltanPeter
Copy link
Collaborator

Without having reviewed in detail, I'm wondering if this update is premature? Waku specs repo indeed has a new version of the lightpush spec as experimental improvement, but I would suggest that the implementation and deployment reach some level of maturity before we replace the existing RFC (as this one is already in draft and matches the implementation). Both versions of the protocol will be supported for a while @NagyZoltanPeter can comment on maturity of the "new" protocol implementation. Once most clients have switched over, we can deprecate the old lightpush version - both the RFC and the implementation.

Thanks @jm-clius, yes. new redesigned v2 of lightpush protocol is under development, spec available here: https://github.com/waku-org/specs/blob/master/standards/core/lightpush.md cc: @jimstir, of course any comments are welcome.

@jimstir sorry I did not see your changes are based upon that spec... but yes, we are planning to have a slow rollover to the new protocol, leaving enough time to switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants