-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19/WAKU2-LIGHTPUSH: Update #112
base: main
Are you sure you want to change the base?
Conversation
- or perform another requested service. | ||
`Services beyond [11/WAKU2-RELAY](/waku/standards/core/11/relay.md) are yet to be defined.` | ||
|
||
Depending on the network configuration, the lightpush client may not need to provide `pubsub_topic`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can a light node (edge node) and a service node be considered a lightpush client
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Within the context of lightpush
and other req-resp protocols the protocol agents are always client and service node ("server" is sometimes used though somewhat less accurate IMO). I would stay away from "light node"/"edge node" within the context of req-resp protocol specifications. I think it's OK to use these terms in the motivation/background part only to explain why some nodes may choose to act as lightpush client. Edge nodes would typically prefer client mode, though these nodes all exist on a continuum of resource usage. In other words, "lightpush client" would be correct in this specific context as it refers to protocol behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without having reviewed in detail, I'm wondering if this update is premature? Waku specs repo indeed has a new version of the lightpush spec as experimental improvement, but I would suggest that the implementation and deployment reach some level of maturity before we replace the existing RFC (as this one is already in draft
and matches the implementation). Both versions of the protocol will be supported for a while @NagyZoltanPeter can comment on maturity of the "new" protocol implementation. Once most clients have switched over, we can deprecate the old lightpush version - both the RFC and the implementation.
Thanks @jm-clius, yes. new redesigned v2 of lightpush protocol is under development, spec available here: https://github.com/waku-org/specs/blob/master/standards/core/lightpush.md |
@jimstir sorry I did not see your changes are based upon that spec... but yes, we are planning to have a slow rollover to the new protocol, leaving enough time to switch. |
Updating the 19/WAKU2-LIGHTPUSH rfc. Waku specs repo has a new rfc becuase the current specification is under specified. Information from that update is included with some changes. Also introduced the term edge nodes in this update.