Status old RFCs - moving to RFC Index #109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimstir
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Left a few comments that should be fixed. All specs should be in deprecated and placed in a status deprecated folder. (e.g.status/deprecated/1/client.md) Also the .obsidian subfolder should be removed. And there are some links in status specs in this repo that link to specs.status, they should be updated.
status/1/client.md
Outdated
Comment on lines
28
to
52
| ## Table of Contents | ||
|
|
||
| - Abstract | ||
| - Table of Contents | ||
| - Introduction | ||
| - Protocol layers | ||
| - Protobuf | ||
| - Components | ||
| - P2P Overlay | ||
| - Node discovery and roles | ||
| - Bootstrapping | ||
| - Discovery | ||
| - Mobile nodes | ||
| - Transport privacy and Whisper/Waku usage | ||
| - Secure Transport | ||
| - Data Sync | ||
| - Payloads and clients | ||
| - BIPs and EIPs Standards support | ||
| - Security Considerations | ||
| - Design Rationale | ||
| - P2P Overlay | ||
| - Why devp2p? Why not use libp2p? | ||
| - What about other RLPx subprotocols like LES and Swarm? | ||
| - Why do you use Whisper? | ||
| - Why do you use Waku? |
There was a problem hiding this comment.
The table of contents and the list can be removed for all the specs.
status/1/client.md
Outdated
Comment on lines
2
to
5
| slug: 1 | ||
| title: 1/CLIENT | ||
| name: Client | ||
| status: draft |
There was a problem hiding this comment.
Remove the slug and the number in front of the title for all the specs.
status/1/client.md
Outdated
|
|
||
| A Mobile node is a Whisper and/or Waku node connecting to the network. | ||
| Mobile nodes **MAY** relay messages. | ||
| See 3/WHISPER-USAGE and 10/WAKU-USAGE for more details. |
There was a problem hiding this comment.
Remove the slugs for references in each spec.
status/9/ethereum-usage.md
Outdated
| Status nodes rely on these Infura nodes | ||
| to validate transaction integrity and report consistent history. | ||
|
|
||
| [Key handling is described here](https://specs.status.im/spec/2-account.md) |
There was a problem hiding this comment.
Update links for specs being moved to this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.