Skip to content

Commit

Permalink
use input instead of button to fix local failures
Browse files Browse the repository at this point in the history
  • Loading branch information
vursen committed Jan 8, 2025
1 parent e251198 commit d04d73b
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion packages/checkbox-group/test/checkbox-group.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ describe('vaadin-checkbox-group', () => {
beforeEach(async () => {
[firstGlobalFocusable, group] = fixtureSync(
`<div>
<button>First global focusable</button>
<input id="first-global-focusable" />
<vaadin-checkbox-group>
<vaadin-checkbox value="1" label="Checkbox 1"></vaadin-checkbox>
</vaadin-checkbox-group>
Expand Down
2 changes: 1 addition & 1 deletion packages/checkbox-group/test/validation.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('validation', () => {
beforeEach(async () => {
[firstGlobalFocusable, group] = fixtureSync(
`<div>
<button>First global focusable</button>
<input id="first-global-focusable" />
<vaadin-checkbox-group>
<vaadin-checkbox name="language" value="en" label="English"></vaadin-checkbox>
<vaadin-checkbox name="language" value="fr" label="Français"></vaadin-checkbox>
Expand Down
2 changes: 1 addition & 1 deletion packages/checkbox/test/validation.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('validation', () => {
checkbox = fixtureSync(
`<div>
<vaadin-checkbox label="Checkbox"></vaadin-checkbox>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).firstElementChild;
await nextRender();
Expand Down
2 changes: 1 addition & 1 deletion packages/combo-box/test/interactions.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe('interactions', () => {
comboBox = fixtureSync(
`<div>
<vaadin-combo-box label="Label"></vaadin-combo-box>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).firstElementChild;

Expand Down
2 changes: 1 addition & 1 deletion packages/combo-box/test/keyboard.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe('keyboard', () => {
[comboBox, lastGlobalFocusable] = fixtureSync(
`<div>
<vaadin-combo-box></vaadin-combo-box>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).children;

Expand Down
2 changes: 1 addition & 1 deletion packages/dashboard/test/dashboard-keyboard.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('dashboard - keyboard interaction', () => {
beforeEach(async () => {
[firstGlobalFocusable, dashboard] = fixtureSync(
`<div>
<button>First global focusable</button>
<input id="first-global-focusable" />
<vaadin-dashboard></vaadin-dashboard>
</div>`,
).children as unknown as [HTMLElement, Dashboard<TestDashboardItem>];
Expand Down
2 changes: 1 addition & 1 deletion packages/date-picker/test/dropdown.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ describe('dropdown', () => {
datePicker = fixtureSync(
`<div>
<vaadin-date-picker></vaadin-date-picker>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).firstElementChild;
await nextRender();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('virtual-keyboard-controller', () => {
element = fixtureSync(
`<div>
<virtual-keyboard-controller-element></virtual-keyboard-controller-element>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).firstElementChild;
input = element.inputElement;
Expand Down
2 changes: 1 addition & 1 deletion packages/multi-select-combo-box/test/readonly.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe('readonly', () => {
comboBox = fixtureSync(
`<div>
<vaadin-multi-select-combo-box readonly></vaadin-multi-select-combo-box>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).firstElementChild;
comboBox.items = ['apple', 'banana', 'lemon', 'orange'];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe('keyboard navigation', () => {
<vaadin-radio-button label="Button 2" value="2"></vaadin-radio-button>
<vaadin-radio-button label="Button 3" value="3"></vaadin-radio-button>
</vaadin-radio-group>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).firstElementChild;
await nextFrame();
Expand Down
2 changes: 1 addition & 1 deletion packages/radio-group/test/radio-group.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ describe('radio-group', () => {
beforeEach(async () => {
[firstGlobalFocusable, group] = fixtureSync(
`<div>
<button>First global focusable</button>
<input id="first-global-focusable" />
<vaadin-radio-group>
<vaadin-radio-button label="Button 1"></vaadin-radio-button>
<vaadin-radio-button label="Button 2"></vaadin-radio-button>
Expand Down
2 changes: 1 addition & 1 deletion packages/radio-group/test/validation.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('validation', () => {
beforeEach(async () => {
[firstGlobalFocusable, group] = fixtureSync(
`<div>
<button>First global focusable</button>
<input id="first-global-focusable" />
<vaadin-radio-group>
<vaadin-radio-button label="Button 1" value="1"></vaadin-radio-button>
<vaadin-radio-button label="Button 2" value="2"></vaadin-radio-button>
Expand Down
2 changes: 1 addition & 1 deletion packages/select/test/validation.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe('validation', () => {
select = fixtureSync(
`<div>
<vaadin-select></vaadin-select>
<button>Last global focusable</button>
<input id="last-global-focusable" />
</div>`,
).firstElementChild;
select.items = [
Expand Down

0 comments on commit d04d73b

Please sign in to comment.