fix: add return types to forwardRef for IntelliJ completion #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Dec 8, 2023
There was a problem hiding this comment.
For some reason, I still see a very limited list of options for these components on IntelliJ:
There was a problem hiding this comment.
How did you test it? I was copying the .d.ts file and for me it worked:
There was a problem hiding this comment.
I used npm link @hilla/react-components on docs
There was a problem hiding this comment.
Using npm link for me makes code completion popup not show at all (IntelliJ 2022.2.5). Will try latest IDEA.
|
Closing in favor of #167 which resolves the original issue in the latest version of IntelliJ IDEA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #165
Added type cast to components using
forwardRefsimilar to how it's done in other cases, especiallyNotificationand components with generics e.g.Grid. This is a workaround for the IntelliJ bug related toForwardRefExoticComponent.Note: I also had to add special helper to omit properties starting with underscore using TS template literal types.
Otherwise, code completion popup for
DateTimePicker,SelectandTimePickerwould look like this:There is no need to use this for
ContextMenuandDialogas they don't expose protected properties.Type of change