fix: override all methods when patching data generator

vaadin · Nov 12, 2024 · 982bb82 · 982bb82
1 parent c359c25
commit 982bb82
Showing 1 changed file with 25 additions and 4 deletions.
diff --git a/...-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java b/...-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
@@ -496,10 +496,31 @@ public Column(Grid<T> grid, String columnId, Renderer<T> renderer) {
 
             if (dataGenerator.isPresent()) {
                 var generator = dataGenerator.get();
-                DataGenerator<T> conditionalDataGenerator = (item,
-                        jsonObject) -> {
-                    if (Column.this.isVisible()) {
-                        generator.generateData(item, jsonObject);
+
+                // Use an anonymous class instead of Lambda to prevent potential
+                // deserialization issues when used with Grid
+                // see https://github.com/vaadin/flow-components/issues/6256
+                var conditionalDataGenerator = new DataGenerator<T>() {
+                    @Override
+                    public void generateData(T item, JsonObject jsonObject) {
+                        if (Column.this.isVisible()) {
+                            generator.generateData(item, jsonObject);
+                        }
+                    }
+
+                    @Override
+                    public void destroyData(T item) {
+                        generator.destroyData(item);
+                    }
+
+                    @Override
+                    public void destroyAllData() {
+                        generator.destroyAllData();
+                    }
+
+                    @Override
+                    public void refreshData(T item) {
+                        generator.refreshData(item);
                     }
                 };
                 columnDataGeneratorRegistration = grid