[DAR-4140][External] Fixed NifTI import orientation #953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the
NifTI
importer attempts to apply theLPI
orientation to annotations to be imported, since all uploaded NifTI / DICOM files are transformed toLPI
. However, the used function (apply_orientation()
) flips all 3 axes. Why? TheLPI
orientation can be represented by[-1, -1, -1]
, which we feed into the function as the target orientation. However, that function just flips an axis if the corresponding value in the above 3-element array is -1, and doesn't flip if not. This means that for any input orientation not inRAS
, at least one axis will be flipped incorrectlySolution
Simplify the
process_nifti
function so that:RAS
, regardless of the state oflegacy
Changelog
Resolved orientation issue when importing annotations in the
NifTI
format