[DAR-3771][External] Import of annotation-level properties #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiKlymchuk
approved these changes
Sep 12, 2024
umbertoDifa
reviewed
Sep 13, 2024
| @@ -38,6 +42,7 @@ def base_property_object(base_property_value: PropertyValue) -> FullProperty: | |||
| annotation_class_id=0, | |||
| property_values=[base_property_value], | |||
| options=[base_property_value], | |||
| granularity=PropertyGranularity("section"), | |||
There was a problem hiding this comment.
This is questionable: currently the BE has a default 'section' if no granularity is provided. Here we're building a fixture that disregards the BE default. It's not wrong, but I think it'd be interesting to also have a test that doesn't specify the granularity at all when creating a property
There was a problem hiding this comment.
The unit tests I just added test creating section-level properties from a manifest file where no granularity is specified
JBWilkie
force-pushed
the
DAR-3771
branch
2 times, most recently
from
93d1f4b to
0cba8ac
Compare
JBWilkie
commented
Sep 16, 2024
Comment on lines
370
to
+375
| ): # using numel() to check if tensor is non-empty | ||
| print("WE GOT MASKS") | ||
| albumentation_dict["masks"] = masks.numpy() | ||
| if isinstance(masks, torch.Tensor): | ||
| masks = masks.numpy() | ||
| if masks.ndim == 3: # Ensure masks is a list of numpy arrays | ||
| masks = [masks[i] for i in range(masks.shape[0])] | ||
| albumentation_dict["masks"] = masks |
There was a problem hiding this comment.
Change that is unrelated to the ticket, but necessary to resolve these failing tests:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
darwin-py is currently incapable of handling:
granularityfield in the.v7/metadata.jsonproperties manifest fileframe_index=nullvalues for annotation-level property valuesBoth concepts must be supported by darwin-py to allow the same import functionality as section-level properties (which are currently supported properties)
Solution
Propertyclass withgranularityPropertyGranularityenum to represent the 3 property granularitiesAdjusted the properties import functions to ensure :
granularityis optional so that section-level property values can still be importedWe also add unit tests for
_import_annotations, as none previously existed. These test that for both section & annotation-level properties:granularityChangelog
Added support for annotation-level properties