Skip to content

Commit

Permalink
enhance: add NEXT_PUBLIC_FOOTER_COPYRIGHT to customize footer text, a…
Browse files Browse the repository at this point in the history
…dd UPGRADE_NOTES.md (#26)

Co-authored-by: Roland Schlaefli <[email protected]>
  • Loading branch information
mxmlnwbr and rschlaefli authored Mar 4, 2024
1 parent b2fcce1 commit e7165c9
Show file tree
Hide file tree
Showing 7 changed files with 77 additions and 4 deletions.
1 change: 1 addition & 0 deletions .env.development
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ PROPOSAL_FEEDBACK_URL="https://prod-14.switzerlandnorth.logic.azure.com:443/work
NEXT_PUBLIC_CONTAINER_NAME=uploads
NEXT_PUBLIC_AZURE_STORAGE_ACCOUNT_NAME=thesisplatformdev
FLOW_SECRET=abcd
NEXT_PUBLIC_FOOTER_COPYRIGHT="Department of Finance, University of Zurich. All rights reserved."
3 changes: 2 additions & 1 deletion .env.local.template
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ PROPOSAL_FEEDBACK_URL=
NEXT_PUBLIC_CONTAINER_NAME=
NEXT_PUBLIC_AZURE_STORAGE_ACCOUNT_NAME=
FLOW_SECRET=
APPLICATION_ACCEPTANCE_URL=
APPLICATION_ACCEPTANCE_URL=
NEXT_PUBLIC_FOOTER_COPYRIGHT=
1 change: 1 addition & 0 deletions .env.production
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ NEXT_PUBLIC_FORMS_URL_SUBMIT="https://forms.office.com/Pages/ResponsePage.aspx?i
NEXT_PUBLIC_BLOBSERVICECLIENT_URL="https://thesisplatformdev.blob.core.windows.net/uploads?"
NEXT_PUBLIC_CONTAINER_NAME=uploads
NEXT_PUBLIC_AZURE_STORAGE_ACCOUNT_NAME=thesisplatformdev
NEXT_PUBLIC_FOOTER_COPYRIGHT="Department of Finance, University of Zurich. All rights reserved."
1 change: 1 addition & 0 deletions .env.stage
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ NEXT_PUBLIC_FORMS_URL_SUBMIT="https://forms.office.com/Pages/ResponsePage.aspx?i
NEXT_PUBLIC_BLOBSERVICECLIENT_URL="https://thesisplatformdev.blob.core.windows.net/uploads?"
NEXT_PUBLIC_CONTAINER_NAME=uploads
NEXT_PUBLIC_AZURE_STORAGE_ACCOUNT_NAME=thesisplatformdev
NEXT_PUBLIC_FOOTER_COPYRIGHT="Department of Finance, University of Zurich. All rights reserved."
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@ COPY . .

ARG NODE_ENV production
ARG NEXT_PUBLIC_APP_URL
ARG NEXT_PUBLIC_FORMS_URL_PUBLISH
ARG NEXT_PUBLIC_FORMS_URL_PUBLISH
ARG NEXT_PUBLIC_FORMS_URL_SUBMIT
ARG NEXT_PUBLIC_BLOBSERVICECLIENT_URL
ARG NEXT_PUBLIC_CONTAINER_NAME "uploads"
ARG NEXT_PUBLIC_AZURE_STORAGE_ACCOUNT_NAME
ARG NEXT_PUBLIC_FOOTER_COPYRIGHT

ENV NEXT_TELEMETRY_DISABLED 1

Expand Down
69 changes: 69 additions & 0 deletions UPGRADE_NOTES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
# Upgrade Notes

## Version 1.0.0

### Sharepoint-Changes

- Made every column consistent with their real ("deep") column name --> see [Thesis Supervisors List](https://uzh.sharepoint.com/sites/UZHBFThesisPlatformDEV/Lists/Thesis%20Supervisors/AllItems.aspx) + removed Topic Areas List:
- Show "ID" column
- Email (Title) -> Email
- Hide old Title column -> see https://medium.com/jumpto365/removing-the-title-field-from-a-sharepoint-list-d58283fbbe67
- Name (field_1) -> Name
- SupervisionMandatory (field_2) -> SupervisionMandatory
- Languages (field_3) -> Languages
- Comments (field_4) -> Comments
- Added Column "EmailNotification" to opt out/in of email notifications when a student posts a proposal in your topic area
- AreasOfInterestV2 deleted and merged to AreasOfInterest (without second list necessary)

## DB-Changes (run Migration)

- Add Comment from student into Frontend (non-required question from last page of Submit Thesis Proposal)

## Flow/Solution Changes

### Thesis Application Acceptance:

- Included Supervisor in CC for Confirmation mail
- Email Subject/Body: Department variable added
- Add name/email of supervisor to application acceptance email

### Thesis Proposal Application:

- Email Subject: Department variable added

### Thesis Proposal Feedback:

- Email Subject/Body: Department variable added
- Email Body: Replaced field_1 with Email

### Thesis Proposal Posting:

- Link to Proposal in Confirmation Email fixed
- Switched to Group Forms:
- updated form link in settings file
- replaced OneDrive connector with SharePoint connector
- Added missing functionality for Further Attachments & Comments
- Update filter to check for "Name" instead of "field_1"
- SupervisorConfirmationEmail:
- Email Subject/Body: Department variable added
- Email Body: Root Url added & link adjusted
- Update filter to check for "Name" instead of "field_1":
- Changed "deep" column name to "Name" instead of "field_1"

### Thesis Proposal Submission:

- Switched to Group Forms:
- updated form link in settings file
- replaced OneDrive connector with SharePoint connector
- Added missing functionality for Further Attachments & Comments
- EmailToSupervisors:
- Email Subject: Department variable added
- StudentConfimationEmail:
- Email Subject/Body: Department variable added

## App Changes

- Filtering of proposals added
- Accept supervision for multiple supervisor proposal applicants
- Display student e-mail on student proposal (to supervisors)
- Add Comment from student into Frontend (non-required question from last page of Submit Thesis Proposal)
3 changes: 1 addition & 2 deletions src/components/Footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ function Footer() {

<p className="py-4 m-0 text-xs leading-5 text-center text-gray-400">
&copy;
{new Date().getFullYear()} Department of Banking and Finance, University
of Zurich. All rights reserved.
{new Date().getFullYear()} {process.env.NEXT_PUBLIC_FOOTER_COPYRIGHT}
</p>
</footer>
)
Expand Down

0 comments on commit e7165c9

Please sign in to comment.