Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobbler option to enable boot ISOs with Secure Boot #3442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keichwa
Copy link
Contributor

@keichwa keichwa commented Nov 13, 2024

For a link to rendered output, see description of https://github.com/SUSE/spacewalk/issues/25768.

@keichwa keichwa marked this pull request as ready for review November 13, 2024 14:26
Copy link
Contributor

@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a few comments. Additionally, maybe it would be helpful to add where can users find the efi? For example:

  1. Execute cobbler distro list to get the distro name (already in the text):
suma:~ # cobbler distro list
   sles15-sp4:1:SUSE
  1. Execute cobbler distro report to get information about the distro files location:
cobbler distro report --name sles15-sp4:1:SUSE
Name                           : sles15-sp4:1:SUSE
Architecture                   : x86_64
...output omitted...
Initrd                         : /usr/share/tftpboot-installation/SLE-15-SP4-x86_64/boot/x86_64/loader/initrd
Kernel                         : /usr/share/tftpboot-installation/SLE-15-SP4-x86_64/boot/x86_64/loader/linux
...output omitted...
  1. See the contents of the boot directory. In the example above, the boot partition is the /usr/share/tftpboot-installation/SLE-15-SP4-x86_64/boot/x86_64/efi file, but this can differ based on the ISO distributor.

To list the names of distributions and profiles stored by {cobbler}, run the commands:

----
# cobbler distro list
# cobbler profile list
cobbler distro list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually wonder, do we want to wrap these with mgrctl exec?

On 4.3, cobbler ... is correct.
On 5.x, it should be mgrctl exec -- cobbler distro list (or profile list)

Note that this applies to all cobbler commands.

----
cobbler buildiso \
--esp="/usr/share/tftpboot-installation/SLE-15-SP6-x86_64/boot/x86_64/efi" \
--iso=--iso=/path/to/boot.iso --distro=<your-distro-label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--iso=--iso=/path/to/boot.iso --distro=<your-distro-label>
--iso=/path/to/boot.iso --distro=<your-distro-label>


With [option]``--esp`` you can enable the build boot ISOs with Secure Boot.
You explicitly specify the EFI System Partition (ESP).
By default, {cobbler} searches for the ESP, and generates one if not found.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the default Cobbler search doesn't work for SUMA, which is why we add this feature :)

Suggested change
By default, {cobbler} searches for the ESP, and generates one if not found.
By default, {cobbler} generates the ESP partition, which disables Secure Boot.

----


With [option]``--esp`` you can enable the build boot ISOs with Secure Boot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in past participle? We build ISOs, but the ISO is built.

Suggested change
With [option]``--esp`` you can enable the build boot ISOs with Secure Boot.
With [option]``--esp`` you can enable the built boot ISOs with Secure Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants