Update libvirt readme #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there's no information about what `cc_username` and `cc_password` stand for. Without knowing the context, it's difficult to search for and figure out what they mean. This PR adds a small reference to contextualize the terms.
moio
reviewed
Sep 9, 2020
backend_modules/libvirt/README.md
Outdated
| @@ -11,7 +11,8 @@ | |||
| - change the `network_name` variable declaration to `null` | |||
| - optionally specify fixed MAC addresses by adding `mac = "CA:FE:BA:BE:00:01"` lines to VM modules | |||
| - if other sumaform users deploy to the same host, or different bridged hosts in the same network, uncomment the `name_prefix` variable declaration in the `base` module to specify a unique prefix for your VMs | |||
| - complete the `cc_password` variable in the `base` module | |||
| - if you have a [SUSE Customer Center (SCC) account](https://scc.suse.com/), fill the in the credentials in the `cc_username` and `cc_password` variables in the `base` module | |||
| - alternatively, if you don't have an SCC account, you may need to update source repositories under [sumaform/salt/repos](https://github.com/uyuni-project/sumaform/tree/master/salt/repos) depending on what VMs you want to provision | |||
There was a problem hiding this comment.
I'd leave this part out. If one does not have SCC credentials, at this point it is just not possible to provision SLE based VMs, while openSUSE or other freely available distros will work fine.
Or what did you have in mind exactly with this point?
There was a problem hiding this comment.
I'm not familiar with how users outside the organization may use the tool, so I wanted to cover both cases just to be sure based on the discussions I had with Dario. If you think the second line doesn't have practical value, I'll remove that bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no information about what
cc_usernameandcc_passwordstand for. Without knowing the context, it's difficult to search for and figure out what they mean. This PR adds a small reference to contextualize the terms.What does this PR change?
This PR updates the libvirt configuration readme with background context.